Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Jan 22, 2013 at 02:04:56PM -0800, Kukjin Kim wrote:
> Felipe Balbi wrote:
> > Hi,
> > 
> Hi Felipe,
> 
> [...]
> 
> > > Right, DWC has version number, but that being the kind of USB controller
> > > (USB 2.0 and USB 3.0)
> > >
> > > DWC2: USB High Speed controller (as also indicated in the patch from
> > > Paul: [RFC PATCH 0/6] DWC2 DesignWare HS OTG driver)
> > > DWC3: USB Super Speed controller
> > >
> > > Is it fine if we use something like shown below, as suggested by you
> earlier ?
> > >
> > > -     { .compatible = "samsung,exynos-dwc3" },
> > > +     { .compatible = "samsung,synopsis-dwc3" }
> > 
> > You're both missing a point here. The synopsys IP driver is called
> > dwc3.ko and that's compatible with synopsys,dwc3. Your glue layer driver
> > (dwc3-exynos.ko) is compatible with your platform, so
> > samsung,exynos-dwc3 sounds correct to me.
> > 
> Hmm...yeah, you're right and agreed.
> 
> However, we need to use more clear name there like "samsung,exynos-dwusb3"
> in compatible, because you know there are lots of other IPs in Synopsis
> Design Ware brand. So we have to include usb in compatible for that.

fair enough.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux