On Monday 21 January 2013 16:28:48 Bjørn Mork wrote:
> Agreed. But I believe the condition should be
>
> if (!(info->flags & FLAG_SEND_ZLP) && !(info->flags & FLAG_MULTI_PACKET)) {
> ..
> } else {
> urb->transfer_flags |= URB_ZERO_PACKET;
> }
>
> to ensure that we send the ZLP in this case.
Why? If a driver wants ZLP, it can set FLAG_SEND_ZLP. Your proposed change
would take away an option from drivers without any gain.
> > Besides you may want the current behavior.
>
> Why? Does it ever make sense to prevent both the short packet and the
> ZLP?
Why not? It is possible and a driver may want it, so why forbid it?
Especially, as in theory it takes least bandwidth as a solution.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
