Best Regards Tianyu Lan -----Original Message----- From: Alan Stern [mailto:stern@xxxxxxxxxxxxxxxxxxx] Sent: Saturday, January 19, 2013 2:50 AM To: Lan, Tianyu Cc: rjw@xxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; sarah.a.sharp@xxxxxxxxxxxxxxx; oneukum@xxxxxxx; linux-usb@xxxxxxxxxxxxxxx Subject: RE: [Resend PATCH V4 0/10] usb: usb port power off mechanism anc expose usb port connect type On Fri, 18 Jan 2013, Lan, Tianyu wrote: > HI Alan: > I just find Rafael's patch has resolved this issue. In this patch, > enable runtime PM right after executing subsystem/driver > .resume_early() callbacks. When do resume(), the device's runtime pm has been enabled. This patch now is already in the v3.8-rc4. > So this patchset will not cause problem with Rafael patch and I have > tested. About the port system suspend/resume() callback, Could I do this in the next step? Well, I guess you don't really need a resume callback now. Leaving the port in its old runtime PM state should be okay, because hub_activate will set the port power correctly. The important thing is that the hardware's actual power level should agree with the runtime PM status. However, you still need to enable async suspend for the port devices. [>>] Ok. This is just to make suspend operation parallely and keep coherent with other kinds of device in the usb core, right? The device_pm_wait_for_dev call isn't needed if the ports don't have a resume callback. Have you tested hibernation as well as system suspend? [>>] I just test and it works. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
