Re: [PATCH v3] USB: prevent overlapping access by usb-storage and usbfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 01/18/2013 10:48 PM, Greg KH wrote:

>> Serialize usb-storage operations with usbfs and 'cat /proc/bus/usb/devices',
>> so that they cannot disturb storage by seemingly harmless control reads.

>> This patch was adapted from 2.4 patches by Pete Zaitcev.  The initial patch of
>> the series dates back to 2004 and it unfortunately wasn't applied to 2.6 in the
>> same form back then (it was applied in another form and immediately reverted).
>> Despite 8+ years passing from that moment, the vendors didn't stop producing
>> USB devices that require this kind of patch. Two recent examples are SanDisk
>> Cruzer Slice 8GB and Kingston DataTraveller 100 G2 32GB.  In the latter case,
>> even the enumeration fails as the INQUIRY command normally takes 2.8 seconds to
>> finish, so 'udev' also comes into action with its control requests, with neither
>> completing normally.

>> Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
>> Cc: stable@xxxxxxxxxxxxxxx

>> ---
>> This patch is atop of 'usb-linus' branch of Greg's tree.
>> It has been boot tested with non-buggy USB stick only.

> I really want to see this tested on the hardware that it is supposed to
> fix the problem for, otherwise it's kind of pointless, right?

   Don't forget that the same code is working in 2.4 for several years. It would
be hard for me, I'm afraid, to arrange testing this on the modern broken h/w in
the near future as I'm being switched from working with MontaVista to another
company starting next week. Also, we've already internally committed v1 of the
patch as the fix for the issue...

> thanks,

> greg k-h

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux