On 01/18/2013 10:58 AM, Felipe Balbi wrote: > On Fri, Jan 18, 2013 at 10:28:38AM -0700, Stephen Warren wrote: >> On 01/18/2013 08:30 AM, Alan Stern wrote: >>> On Fri, 18 Jan 2013, Venu Byravarasu wrote: >>> >>>> As Tegra PHY driver needs to access one of the Host >>>> registers, added few APIs. >>>> >>>> Signed-off-by: Venu Byravarasu <vbyravarasu@xxxxxxxxxx> --- >>>> delta from v2: Renamed USB_PORTSC1 to TEGRA_USB_PORTSC1. >>>> Removed tegra_ehci_set_wakeon_events() and its references. >>>> Used standard defines for accessing PORTSC fields defined in >>>> ehci_def.h Included OCC bit of PORTSC as part of >>>> TEGRA_PORTSC1_RWC_BITS. >>>> >>>> delta from v1: Taken care of RWC bits, while accessing PORTSC >>>> register. >>> >>> Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> >> >> Felipe, you said on a previous version that you weren't sure if >> you could ack this since it means the PHY driver is touching >> EHCI registers... I don't think we really have much choice w.r.t. >> what the driver is doing, since it's driven purely by HW design. >> Is this updated patched at least OK for you not to NAK it, and >> hence I can apply it? Thanks. > > Sure I will not block it, please go ahead and apply it through your > tree ;-) Great, thanks very much. Are patch 2/4 and 3/4 OK; could you Ack them since they touch USB PHY code? I guess in the interests of moving this USB rework forward, I'll actually fix up the issue with assigning phy->is_ulpi_phy while I apply the patches, just by moving that one chunk of code from patch 4 to patch 3. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
