Re: [PATCH 1/1] USB: io_ti: Fix NULL dereference in chase_port()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 17, 2013 at 01:07:02AM +0100, Wolfgang Frisch wrote:
> The tty is NULL when the port is hanging up.
> chase_port() needs to check for this.
> 
> This patch is intended for stable series.
> The behavior was observed and tested in Linux 3.2 and 3.7.1.
> 
> Johan Hovold submitted a more elaborate patch for the mainline kernel.

[...]

> Signed-off-by: Wolfgang Frisch <wfpub@xxxxxxxxxxxx>

Acked-by: Johan Hovold <jhovold@xxxxxxxxx>

Greg, this one should go into v3.8-rc and the stable trees.

I'll resend my series that remove the no-longer-needed chase_port() once
this patch has made it to usb-next.

Thanks,
Johan


> ---
>  drivers/usb/serial/io_ti.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c
> index 60023c2..ed83e7a 100644
> --- a/drivers/usb/serial/io_ti.c
> +++ b/drivers/usb/serial/io_ti.c
> @@ -534,6 +534,9 @@ static void chase_port(struct edgeport_port *port, unsigned long timeout,
>  	wait_queue_t wait;
>  	unsigned long flags;
> 
> +	if (!tty)
> +		return;
> +
>  	if (!timeout)
>  		timeout = (HZ * EDGE_CLOSING_WAIT)/100;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux