Hi, On Thu, Jan 17, 2013 at 04:34:45PM +0530, Pratyush Anand wrote: > Hi Felip, > > On 1/17/2013 4:14 PM, Pratyush ANAND wrote: > >dwc3_gadget_set_ep_config expects maxburst as incremented by 1. So, by > >default initialize ep->maxburst to 0 for ep0. > > > > Although , this patch fixes issue of maxburst for default control > endpoint. But, I could not understand purpose of following patch..May > be I am missing something.. > > usb: gadget: composite: fix ep->maxburst initialization > > Since at every other places, maxburst takes value same as bMaxburst > size(like isoc_maxburst in f_sourcesink.c), so why should we use an > incremented one in composite.c and decrement it again in peripheral > driver. I don't think the patch above is wrong, we don't know how other controllers behave, some might require bMaxBurst + 1 and some might require bMaxBurst, we're just making sure that whatever the gadget framework sees is the real number (meaning that the smallest is 1). $SUBJECT is perfectly sound and should be backported to stable as soon as you fix the commit log :-) -- balbi
Attachment:
signature.asc
Description: Digital signature
