On 01/16/2013 09:37 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 01/16/2013 05:43 PM, Roger Quadros wrote:
>
>> Use devm_ variants of kzalloc() and ioremap(). Simplify the error path.
>
>> Signed-off-by: Roger Quadros <rogerq@xxxxxx>
>> ---
>> drivers/mfd/omap-usb-tll.c | 36 +++++++++++-------------------------
>> 1 files changed, 11 insertions(+), 25 deletions(-)
>
>> diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
>> index 9658e18..53ed10b 100644
>> --- a/drivers/mfd/omap-usb-tll.c
>> +++ b/drivers/mfd/omap-usb-tll.c
> [...]
>> - base = ioremap(res->start, resource_size(res));
>> + base = devm_request_and_ioremap(dev, res);
>> if (!base) {
>> - dev_err(dev, "TLL ioremap failed\n");
>> ret = -ENOMEM;
>
> -EADDRNOTAVAIL as the comment to devm_request_and_ioremap() suggests.
>
I changed it deliberately to ENOMEM, as I could not find EADDRNOTAVAIL
defined in all architectures.
ENOMEM shouldn't harm.
cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
