On Thu, Jan 17, 2013 at 7:37 AM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Sat, 5 Jan 2013 10:25:38 +0800
> Ming Lei <ming.lei@xxxxxxxxxxxxx> wrote:
>
>> This patchset try to solve one deadlock problem which might be caused
>> by memory allocation with block I/O during runtime PM and block device
>> error handling path. Traditionly, the problem is addressed by passing
>> GFP_NOIO statically to mm, but that is not a effective solution, see
>> detailed description in patch 1's commit log.
>>
>> This patch set introduces one process flag and trys to fix the deadlock
>> problem on block device/network device during runtime PM or usb bus reset.
>
> The patchset doesn't look like the worst thing I've ever applied ;)
>
> One thing I'm wondering: during suspend and resume, why are GFP_KERNEL
> allocation attempts even getting down to the device layer? Presumably
> the page scanner is encountering dirty pagecache or dirty swapcache
> pages?
>
> If so, I wonder if we could avoid the whole problem by appropriately
> syncing all dirty memory back to storage before starting to turn devices
> off?
The patchset is to address the probable deadlock problem by GFP_KERNEL
during runtime suspend/resume which is per block/network device. I am
wondering if syncing all dirty memory is suitable or necessary during
per-storage/network device runtime resume/suspend:
- sys_sync is very slow and runtime pm operation is frequent
- it is not efficient because only sync dirty memory against the affected
device is needed in theory and not necessary to sync all
- we still need some synchronization to avoid accessing the storage
between sys_sync and device suspend, just like system sleep case,
pm_restrict_gfp_mask is needed even sys_sync has been done
inside enter_state().
So looks the approach in the patch is simpler and more efficient, :-)
Also, with the patchset, we can avoid many GFP_NOIO allocation
which is fragile and not easy to use.
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
