Hello. On 01/16/2013 05:43 PM, Roger Quadros wrote: > Use devm_ variants of kzalloc and ioremap. Also clean up error path. > Signed-off-by: Roger Quadros <rogerq@xxxxxx> [...] > diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c > index 061366d..0f190b6 100644 > --- a/drivers/mfd/omap-usb-host.c > +++ b/drivers/mfd/omap-usb-host.c > @@ -461,15 +461,20 @@ static int usbhs_omap_probe(struct platform_device *pdev) [...] > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "uhh"); > + omap->uhh_base = devm_request_and_ioremap(dev, res); > + if (!omap->uhh_base) { > + dev_err(dev, "Resource request/ioremap failed\n"); > + return -ENOMEM; Should be -EADDRNOTAVAIL according to the comment to devm_request_and_ioremap()... WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html