Hi Tomasz, On Wed, Jan 16, 2013 at 1:19 PM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote: > Hi Vivek, > > Don't you need also some clkdev lookup entry to make the clock available > in the driver? > This clock source we added with a motive of completion, however it's not being used as of now. As far as i could see the lookup structure contains clocks for devices having multiple instances. Do you feel that i should be adding an entry in clk_lookup structure ? May be i am missing here something. Can you please elaborate on the use-case of clk_lookup entries. > > On Tuesday 15 of January 2013 19:08:31 Vivek Gautam wrote: >> Adding necessary device clock to exynos5 needed for >> the DWC3 controller. >> >> Signed-off-by: Vivek Gautam <gautam.vivek@xxxxxxxxxxx> >> --- >> arch/arm/mach-exynos/clock-exynos5.c | 24 ++++++++++++++++++++++++ >> 1 files changed, 24 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/clock-exynos5.c >> b/arch/arm/mach-exynos/clock-exynos5.c index 0208c3a..13af020 100644 >> --- a/arch/arm/mach-exynos/clock-exynos5.c >> +++ b/arch/arm/mach-exynos/clock-exynos5.c >> @@ -757,6 +757,11 @@ static struct clk exynos5_init_clocks_off[] = { >> .enable = exynos5_clk_ip_fsys_ctrl , >> .ctrlbit = (1 << 18), >> }, { >> + .name = "usbdrd30", >> + .parent = &exynos5_clk_aclk_200.clk, >> + .enable = exynos5_clk_ip_fsys_ctrl, >> + .ctrlbit = (1 << 19), >> + }, { >> .name = "usbotg", >> .enable = exynos5_clk_ip_fsys_ctrl, >> .ctrlbit = (1 << 7), >> @@ -1035,6 +1040,16 @@ static struct clksrc_sources exynos5_clkset_group >> = { .nr_sources = ARRAY_SIZE(exynos5_clkset_group_list), >> }; >> >> +struct clk *exynos5_clkset_usbdrd30_list[] = { >> + [0] = &exynos5_clk_mout_mpll.clk, >> + [1] = &exynos5_clk_mout_cpll.clk, >> +}; >> + >> +struct clksrc_sources exynos5_clkset_usbdrd30 = { >> + .sources = exynos5_clkset_usbdrd30_list, >> + .nr_sources = ARRAY_SIZE(exynos5_clkset_usbdrd30_list), >> +}; >> + >> /* Possible clock sources for aclk_266_gscl_sub Mux */ >> static struct clk *clk_src_gscl_266_list[] = { >> [0] = &clk_ext_xtal_mux, >> @@ -1329,6 +1344,15 @@ static struct clksrc_clk exynos5_clksrcs[] = { >> .parent = &exynos5_clk_mout_cpll.clk, >> }, >> .reg_div = { .reg = EXYNOS5_CLKDIV_GEN, .shift = 4, .size = 3 > }, >> + }, { >> + .clk = { >> + .name = "sclk_usbdrd30", >> + .enable = exynos5_clksrc_mask_fsys_ctrl, >> + .ctrlbit = (1 << 28), >> + }, >> + .sources = &exynos5_clkset_usbdrd30, >> + .reg_src = { .reg = EXYNOS5_CLKSRC_FSYS, .shift = 28, .size = > 1 }, >> + .reg_div = { .reg = EXYNOS5_CLKDIV_FSYS0, .shift = 24, .size = > 4 }, >> }, >> }; -- Thanks & Regards Vivek -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html