On Tue, Jan 08, 2013 at 01:49:00PM +0800, Harvey Yang wrote: > This patchset refines some spinlocks which maybe not used properly. > > [PATCH 1/2]: The function 'usbip_event_add()' may be called in interrupt context on the stub side: > 'stub_complete'->'stub_enqueue_ret_unlink'->'usbip_event_add'. > In this function it tries to get the lock 'ud->lock', so we should disable irq when we get this lock in process context. > > [PATCH 2/2]: On the client side, we have a virtual hcd driver, there actually no hardware interrupts, so we do not need worry about race conditions caused by irq. To achieve a good performance there is no need to use the interrupt safe spinlock. Just replace them with a non interrupt safe version. This information needs to be in the patches itself, otherwise it will never be seen. Also, why do you think this is going to make anything faster? Have you measured it? What are the results? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
