Re: [PATCH v2] usb: chipidea: Allow disabling streaming not only in udc mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Dec 30, 2012 at 06:38:36PM -0200, Fabio Estevam wrote:
> Hi Peter,
> 
> On Sat, Dec 22, 2012 at 9:24 AM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> > From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> >
> > When running a scp transfer using a USB/Ethernet adapter the following crash
> > happens:
> >
> > $ scp test.tar.gz fabio@192.168.1.100:/home/fabio
> > fabio@192.168.1.100's password:
> > test.tar.gz                                      0%    0     0.0KB/s   --:-- ETA
> > ------------[ cut here ]------------
> > WARNING: at net/sched/sch_generic.c:255 dev_watchdog+0x2cc/0x2f0()
> > NETDEV WATCHDOG: eth0 (asix): transmit queue 0 timed out
> > Modules linked in:
> > Backtrace:
> > [<80011c94>] (dump_backtrace+0x0/0x10c) from [<804d3a5c>] (dump_stack+0x18/0x1c)
> >  r6:000000ff r5:80412388 r4:80685dc0 r3:80696cc0
> > [<804d3a44>] (dump_stack+0x0/0x1c) from [<80021868>]
> > (warn_slowpath_common+0x54/0x6c)
> > [<80021814>] (warn_slowpath_common+0x0/0x6c) from [<80021924>]
> > (warn_slowpath_fmt+0x38/0x40)
> > ...
> >
> > Setting SDIS (Stream Disable Mode- bit 4 of USBMODE register) fixes the problem.
> >
> > However, in current code CI13XXX_DISABLE_STREAMING flag is only set in udc mode,
> > so allow disabling streaming also in host mode.
> >
> > Tested on a mx6qsabrelite board.
> >
> > Suggested-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> > Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> 
> Does this look goog now? If so, can you Ack it?

Hi Fabio, I am not the maintainter, it looks ok. I add my
Reviewed-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>

> 
> Regards,
> 
> Fabio Estevam
> 

-- 

Best Regards,
Peter Chen

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux