Re: [PATCH] ehci: make debug port in-use detection functional again

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 19, 2012 at 11:52:42AM -0500, Alan Stern wrote:
> On Wed, 19 Dec 2012, Jan Beulich wrote:
> 
> > Debug port in-use determination must be done before the controller gets
> > reset the first time, i.e. before the call to ehci_setup() as of commit
> > 1a49e2ac9651df7349867a5cf44e2c83de1046af. That commit effectively
> > rendered commit 9fa5780beea1274d498a224822397100022da7d4 useless.
> 
> Quite right, thank you for finding and fixing this.
> 
> > While moving that code around, also fix the BAR determination - the
> > respective capability field is a 3- rather than a 2-bit one -, and use
> > PCI_CAP_ID_DBG instead of the literal 0x0a.
> > 
> > It's unclear to me whether the debug port functionality is important
> > enough to warrant fixing this in stable kernels too.
> 
> I think we should.  Greg, please queue this for all stable kernels that 
> include the 1a49e2ac commit.

Ok, will do.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux