On Wed, 19 Dec 2012, Octavio Alvarez wrote: > On Wed, 19 Dec 2012 07:29:23 -0800, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > wrote: > >> + ohci_dbg(ohci, "marked as bad wakeup.\n"); > > > > I'd prefer the message to be something more like "enabled nVidia/SiS > > wakeup quirk". > > To me, the stupid end-user, both messages are useless. I don't know You, the stupid end-user, would not see this message at all under normal circumstances. It uses the ohci_dbg macro and therefore will not appear unless your kernel is built with CONFIG_USB_DEBUG enabled. > that that means or implies. I would go with: > "Disabled OHCI wakeup (USB) due to faulty controller (no-wakeup.txt)" > > and have a file named no-wakeup.txt under Documentation with this: > > " > Users have reported OHCI misbehavior consisting on false wakeups right > after suspend to RAM on some OHCI controllers, particularly from nVIDIA > and SiS. For those controllers, wakeups has been disabled. > > The system will not be able to wake up the system from suspend > to RAM from an OHCI (USB) device. > > To see the list of affected controllers do: > > grep -B 3 ohci_quirk_bad_wakeup linux-pm/drivers/usb/host/ohci-pci.c > > Bug is tracked at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=677472 > " It wouldn't hurt to include a URL for the bug report in a comment. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
