Re: [PATCH 1/1] usb: host: xhci: remove unused trb var in xhci_irq()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Javier,

Thanks for catching this!  The patch is going to have to wait until
after the 3.8 merge window closes, since I believe Greg isn't accepting
usb-next pull requests yet.

Sarah Sharp

On Sun, Dec 16, 2012 at 04:21:31AM +0100, Javier Martinez Canillas wrote:
> The union xhci_trb *trb variable is defined and assigned
> inside the xHCI IRQ handler function but is never used.
> 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>
> ---
>  drivers/usb/host/xhci-ring.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index cbb44b7..b1b6abb 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -2697,13 +2697,11 @@ irqreturn_t xhci_irq(struct usb_hcd *hcd)
>  {
>  	struct xhci_hcd *xhci = hcd_to_xhci(hcd);
>  	u32 status;
> -	union xhci_trb *trb;
>  	u64 temp_64;
>  	union xhci_trb *event_ring_deq;
>  	dma_addr_t deq;
>  
>  	spin_lock(&xhci->lock);
> -	trb = xhci->event_ring->dequeue;
>  	/* Check if the xHC generated the interrupt, or the irq is shared */
>  	status = xhci_readl(xhci, &xhci->op_regs->status);
>  	if (status == 0xffffffff)
> -- 
> 1.7.7.6
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux