Re: [PATCH v8] usb_8dev: Add support for USB2CAN interface from 8 devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This informations could be useful for configuration scripts. Various
drivers do the same.

regards,
Bernd



2012/12/15 Oliver Hartkopp <socketcan@xxxxxxxxxxxx>

    On 15.12.2012 07:53, Bernd Krumboeck wrote:

    > +++ b/Documentation/ABI/testing/sysfs-driver-usb_8dev
    > @@ -0,0 +1,13 @@
    > +What:                /sys/bus/usb/devices/<busnum>-<devnum>:<config
num>.<interface num>/firmware
    > +Date:                December 2012
    > +Contact:     Bernd Krumboeck <krumboeck@xxxxxxxxxxxxxxx>
    > +Description:
    > +             Returns the firmware version in the form
"<major>.<minor>".
    > +             This file is readonly.
    > +
    > +What:                /sys/bus/usb/devices/<busnum>-<devnum>:<config
num>.<interface num>/hardware
    > +Date:                December 2012
    > +Contact:     Bernd Krumboeck <krumboeck@xxxxxxxxxxxxxxx>
    > +Description:
    > +             Returns the hardware version in the form
"<major>.<minor>".
    > +             This file is readonly.


    Hello Bernd,

    sorry but probably i missed the discussion about this point:

    Why do your create some extra sysfs entries for plain static
information that
    could be retrieved from the syslog too?

    E.g. when attaching the PCAN USB, i get this:

    usb 2-1.3: new full-speed USB device number 6 using ehci-pci
    usb 2-1.3: New USB device found, idVendor=0c72, idProduct=000c
    usb 2-1.3: New USB device strings: Mfr=0, Product=3, SerialNumber=0
    usb 2-1.3: Product: VER1:PEAK
    VER2:02.8.01
    DAT :06.05.2004
    TIME:09:35:37
                                 ...
    peak_usb 2-1.3:1.0: PEAK-System PCAN-USB adapter hwrev 28 serial
FFFFFFFF (1 channel)
    peak_usb 2-1.3:1.0 can2: attached to PCAN-USB channel 0 (device 67)
    usbcore: registered new interface driver peak_usb

    Don't you think it's a better idea to add an additional line to the
syslog
    telling about this *static* hw/sw information than adding the extra
complexity
    and documentation for the sysfs handling?

    Regards,
    Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux