Hi, On Fri, Dec 14, 2012 at 03:50:57PM +0400, Sergei Shtylyov wrote: > Hello. > > On 26-11-2012 23:14, Sergei Shtylyov wrote: > > >>WARNING: vmlinux.o(.devinit.text+0x24ac): Section mismatch in reference from the function dma_controller_create() to the function .init.text:cppi_controller_start() > >>The function __devinit dma_controller_create() references > >>a function __init cppi_controller_start(). > >>If cppi_controller_start is only used by dma_controller_create then > >>annotate cppi_controller_start with a matching annotation. > > >>This warning is there due to the deficiency in the commit 07a67bbb (usb: musb: > >>Make dma_controller_create __devinit). > > >>Since the start() method is only called from musb_init_controller() which is > >>marked '__devinit', mark cppi_controller_start() '__devinit' and also mark > >>cppi_pool_init() as such since it gets called from that function, to avoid > >>another section mismatch warning... > > >>Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> > >>Cc: stable@xxxxxxxxxxxxxxx # 3.7+ > > >>--- > >>This patch is atop of 'musb' branch of Felipe's tree... > > >>Would be good to have it in 3.7 as an amendment to the patch > >>that went into 3.7-rc1, but if not, I CC'ed stable kernels. > > > Felipe, are you going to finally queue this one? > > Hm, I saw patches removing __devinit from all files floating -- > have they gotten into 3.8-rc1? Looking at musb_init_controller() I > see that yes, they have... So this patch needs to be recast... ok, then please resend. Probably what you want is to remove all such annotations if they're still left in the driver. -- balbi
Attachment:
signature.asc
Description: Digital signature
