Re: EZUSB build failures (was Re: [opensuse-kernel] [PATCH] Fix armv7 kernel-default config)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/12/12 10:59 AM, Jeff Mahoney wrote:
> On 12/12/12 10:07 AM, Greg KH wrote:
>> On Wed, Dec 12, 2012 at 11:39:33AM +0100, Guillaume Gardet
>> wrote:
>>> Hi,
>>> 
>>> please find in attachment a patch to fix armv7 kernel-default 
>>> config.
>>> 
>>> CONFIG_USB_EZUSB_FX2 must be a module instead of built-in to
>>> fix build
> 
>> What build problem?  This should be resolved properly upstream
>> if it is still an issue.  I thought I fixed it a while ago, if
>> not, please let me know upstream.
> 
> Hi Greg -
> 
> Here's what I'm seeing on x86_64 w/ 3.7-final: ERROR:
> "ezusb_fx1_ihex_firmware_download" 
> [drivers/usb/serial/whiteheat.ko] undefined! ERROR:
> "ezusb_fx1_ihex_firmware_download" 
> [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR:
> "ezusb_fx1_set_reset" [drivers/usb/serial/keyspan_pda.ko] 
> undefined! ERROR: "ezusb_fx1_ihex_firmware_download" 
> [drivers/usb/serial/keyspan.ko] undefined!
> 
> Somehow the exported symbols aren't being made available to
> modules when ezusb is a built-in.

$ nm drivers/usb/built-in.o|grep ezusb_fx1_ihex_firmware_download

$ nm drivers/usb/misc/built-in.o |grep ezusb_fx1_ihex_firmware_download
00000000d9b16284 A __crc_ezusb_fx1_ihex_firmware_download
0000000000000000 r __kcrctab_ezusb_fx1_ihex_firmware_download
0000000000000021 r __kstrtab_ezusb_fx1_ihex_firmware_download
0000000000000000 r __ksymtab_ezusb_fx1_ihex_firmware_download
00000000000004d0 T ezusb_fx1_ihex_firmware_download

That'd do it.

Digging a little deeper, it looks like it's because
CONFIG_USB_EZUSB_FX2=y is allowed to be a built-in while CONFIG_USB=m.
drivers/usb/misc gets built with whatever CONFIG_USB is, so it's
treated by drivers/usb as a module and drivers/usb/misc/built-in.o
gets ignored.

I'll post a fix in a minute.

- -Jeff

- -- 
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.18 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iQIcBAEBAgAGBQJQyKziAAoJEB57S2MheeWya6kP/iJ3Ju+tT3qN9PVzRRRF4Nlh
ztFreKxnZi+XAIPgmEUwnFU6IOGVndRP6Q/j474azPUKNzO6B27eflOLWP9t2yqj
Fw0XGCZa1ymTHxUYmvpckwUg1a1iHBnC305GpMs9udWTxYI1xAZIhH3LTowdRNEd
he2gH5eq8jb2CNhK5gkN0meRiRRBpo/UeU251HifnEjkchIE5rZZgMxQc0YJkk9w
x5JSYKLwfWI1uJfh1yco9DwUsp7BnJEXMdONfbWNDnYsKHN5HQlc+9FxNNUOXUvT
sbbxH10ke6jS1AsSGJL3OQPtSbectwp1l/OO5iPbgrqI7sBGYlpi6ho30d1Djgoi
ZfjT/bV6cQ3p2Kz2EydGRBnkEH8WrorVVhzU+QXYNmM8+cHFqmn7i3HCxlgFT2Ya
rPu/+0o/hWTswJcJORIpuUFLWmo9CaFkJMikUZV5WoWvoP7YK8WxUrF+P6PfW7u2
YoYQkyHU3s8Kw0Ic/YLtMBCepUsWnnn+RmBP08CFw4KgYtQzRpu/nXQhlaWe/8OO
994pcs8m/qg9/V6huk5BLWmK8HRnOBDKcG2pPZd5g6Z7idhTpkd2WQcgY85ymeS5
nZ7D+5mqswspsE+9xVLMVwvkWYeZ+Vhs7ire2UUd0rF7bwpewUM5lccpNW5eZi8a
WM0eG6Wve0ygCJ11g2uw
=Jeaz
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux