On Tue, Dec 11, 2012 at 6:27 PM, Oliver Neukum <oliver@xxxxxxxxxx> wrote: > On Tuesday 11 December 2012 10:24:57 Ming Lei wrote: >> On Mon, Dec 10, 2012 at 10:18 PM, Steve Glendinning <steve@xxxxxxxxxxx> wrote: > >> > Thanks, so something like this should do the job? >> >> This will do, but not simple as clearing .manage_power function >> pointer in bind(), and still disable runtime suspend for link off case >> since these devices which don't support suspend 3 can generate >> remote wakeup for link change event. > > So they can autosuspend if the interface is up and no cable is plugged > in? >From the open datasheet, that is the suspend 1 mode, which is supported by all LAN95xx devices. Steve, correct me if I am wrong. > >> I suggest to introduce link-off triggered runtime suspend for these >> usbnet devices(non-LAN9500A device, devices which don't support >> USB auto-suspend), and I have posted one patch set before[1]. >> If no one objects that, I'd like to post them again with some fix and >> update for checking link after link_reset(). > > If you can get rid of a periodic work this would be great. For the LAN95xx devices, the periodic work isn't needed because they may generate remote wakeup when link change is detected. In fact, I have test data which can show a much power save on OMAP3 based beagle board plus asix usbnet device with the periodic work. IMO, the power save after introducing periodic timer depends on the arch or platform, there should be much power save if the CPU power consumption is very less. So how about letting module parameter switch on/off the periodic work? Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
