Alan Stern <stern@...> writes: > > On Mon, 10 Dec 2012, Golmer Palmer wrote: > > > Now, another comment related to the "storage_common.c" file: > > > > Why the limit of "if (num_sectors >= 256*60*75*4)" in function "fsg_lun_open()". > > The limit is 256*60*75 = 1152000. > > > From my point of view (please, correct me if I wrong!), this are 1,152,000 > > sectors. With a 99 minutes (900MB) CD-ROMs, the limit are 445,000 sectors. > > Right. This limit represents a hypothetical 256-minute CD. 256 minutes CD, ok! (75 represents 75 sectors/sec) > > > Nevertheless, with a DVD the maximum sectors are 4,173,824 (DVD-9 DL). So why > > this limit? As we can supose that the driver can work with a DVD ISO image, why > > not increase the limit to DVD specs? > > Although the driver can work with a DVD ISO image, it does not emulate > a DVD. Only a CD. Yes, not a DVD. But if you "mount" a DVD image with the cdrom emulation, it works! So, please, update the limit to 950*60*75 (4,275,000 sectors). This is an hypothetical 950 minutes CD-ROM, with a size bigger than a DVD-9 "DATA" disk. > > > > By the way, that's not the right way to do this. Here's the proper > > > patch. > > > > > > Alan Stern > > > > > > Index: usb-3.7/drivers/usb/gadget/f_mass_storage.c > > > > Thank you, Alan! Please, can you try to push this patch to the main kernel tree? > > Not until somebody tests it and confirms that it fixes the problem. Ok, I'll try to do, over a custom patched Android Kernel (my only hardware platform with USB Gadget support is the phone). > > > I'll like to see this corrected in a new release of the Android Kernel. > > You'll have to talk to the Android people about that. Sure! I'll do *after* the patch is in the Linux Kernel tree. After that, it's more easy to apply it. Regards! -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
