Hi, On Thu, Dec 06, 2012 at 11:46:45AM +0100, Supriya s KARANTH wrote: > Hi Felipe, > > > From: Felipe Balbi [mailto:balbi@xxxxxx] > > Sent: Friday, November 30, 2012 7:51 PM > > > > Hi, > > > > On Fri, Nov 30, 2012 at 12:02:25PM +0530, Supriya Karanth wrote: > > > From: supriya karanth <supriya.karanth@xxxxxxxxxxxxxx> > > > > > > Handles: > > > 1) Known transfer length > > > a) Non multiple of packet size > > > b) Multiple of packet size > > > > > > 2) Unknown transfer lengths > > > - Short packet indicates end of transfer > > > > > > > I'm sorry but this is not enough. You're almost there, however. > > > > What you need to do is cleanup the entire rxstate() and txstate() functions. > > They need to be split into PIO and DMA counter-parts and DMA > > programming has to be done the same way for everybody. All of those > > is_$dma() checks need to go. > > > > Without that, this will never work for everybody. > > > > -- > > balbi > > We agree that the rxstate() and txstate() needs cleanup in order to have the > DMA and PIO programming same for everyone but perhaps we could do this > as part of a separate patch? This might cause regressions in other platforms The problem is that such a "separate patch" will never come unless it is enforced somehow. Whenever people get their part working, they tend to vanish, so I would much rather see the cleanup done first, sorry. -- balbi
Attachment:
signature.asc
Description: Digital signature
