Re: [PATCH v2 13/22] mfd: omap-usb-host: override number of ports from platform data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 03-12-2012 19:58, Roger Quadros wrote:

On 28-11-2012 18:49, Roger Quadros wrote:

Both OMAP4 and 5 exhibit the same revision ID in the REVISION register
but they have different number of ports i.e. 2 and 3 respectively.
So we can't rely on REVISION register for number of ports on OMAP5
and depend on platform data (or device tree) instead.

Signed-off-by: Roger Quadros <rogerq@xxxxxx>
[...]

diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 87b574b..fda235a 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -495,19 +495,27 @@ static int __devinit usbhs_omap_probe(struct
platform_device *pdev)
        */
       pm_runtime_put_sync(dev);

-    switch (omap->usbhs_rev) {
-    case OMAP_USBHS_REV1:
-        omap->nports = 3;
-        break;
-    case OMAP_USBHS_REV2:
-        omap->nports = 2;
-        break;
-    default:
-        omap->nports = OMAP3_HS_USB_PORTS;
-        dev_dbg(dev,
-          "USB HOST Rev : 0x%d not recognized, assuming %d ports\n",
-           omap->usbhs_rev, omap->nports);
-        break;
+    /*
+     * If platform data contains nports then use that
+     * else make out number of ports from USBHS revision
+     */
+    if (pdata->nports) {
+            omap->nports = pdata->nports;

    Overindented line?

Sorry, I didn't get it. Did you mean extra tab/space?

   Extra tab, yes.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux