Hi, On Fri, Nov 30, 2012 at 08:09:38PM +0100, Sebastian Andrzej Siewior wrote: > On 11/30/2012 05:43 PM, Alan Stern wrote: > >By the way, can you name these string attributes > > > > sSerialNumber, sProduct, and sManufacturer (etc.) > > > >instead of > > > > iSerialNumber, iProduct, and iManufacturer (etc.)? > > > >Or is it too late to change? > > Hehe :) Why should it be too late? > > >The iProduct,... names are already defined in the USB spec, and their > >meanings are different from the way you are using them here. Since > >this will be a user-visible API, we should strive to be compatible with > >the spec. > > I wanted to be close to the USB-specification but since it is not an > integer / number but the actual string I guess it make sense. This > change is part of v3. then how about we drop the hungarian notation altogether ? Instead of sManufacturer we follow the host stack and just call it manufacturer. Likewise for all other fields ?? -- balbi
Attachment:
signature.asc
Description: Digital signature
