Peter Chen <peter.chen@xxxxxxxxxxxxx> writes: > On Fri, Nov 16, 2012 at 01:53:09PM +0200, Alexander Shishkin wrote: >> Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx> writes: >> I'd prefer this function to live in ci13xxx_imx, since that's where it's >> used and it doesn't really need anything from core.c anyway. Or maybe it >> would make sense to make it even more generic (for other devitetree >> users), since you're saying that other drivers are using this already. >> >> Looks good to me otherwise. > > I think it supplies a way that the platform can override the usb role, > only freescale uses it, but also other platforms may use it. It is a > generic feature, other chipidea users may need it. I'm not objecting against the flags, I just don't like the function in chipidea core. Platform code can just use the flags. It can be either part of the platform driver or a generic dt helper, in case there are more users, it doesn't belong to chipidea core. Regards, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
