Re: [PATCH 01/10] USB: Set usb port's DeviceRemovable according acpi information in EHCI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 28 Nov 2012, Sarah Sharp wrote:

> > > The shared code to overwrite the bits should probably print a warning if
> > > the host and ACPI bits differ.
> > 
> > I'm not so sure about that.  For one thing, who wants warnings to be 
> > logged every time they run "lsusb -v"?
> 
> Yeah, that's probably not a great idea.
> 
> > Also, this sort of thing might be more common than you might expect.  
> > I'd guess that if the ACPI information contains anything useful at all, 
> > it will be different from the [Ex]HCI information.
> > 
> > Tianyu's patches log such warnings for xHCI but not for EHCI.  That 
> > inconsistency is another reason to rework them.
> 
> Tianyu did that because I asked him to for xHCI.  I didn't think about
> the lsusb implications.  You're right that it will probably be annoying
> to the user, so he should just drop the warning in the shared code.

It could be changed to a dev_dbg.  That wouldn't bother people and it 
might be useful.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux