On Tue, 27 Nov 2012, Sarah Sharp wrote: > Hi Alan, > > Could you take a look at this patchset since you asked Tianyu to > refactor the hub code into new files? Yes, sorry. I've been busy. Tianyu, I think you shouldn't move all the #include lines from hub.c into hub.h. At most, hub.h should have #include lines only for things that it uses directly. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html