Re: [PATCH] cppi_dma: mark cppi_controller_create() and cppi_pool_init() as '__devinit'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Nov 26, 2012 at 10:14:30PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 11/12/2012 09:01 PM, Sergei Shtylyov wrote:
> 
> > This patch fixes the following:
> 
> > WARNING: vmlinux.o(.devinit.text+0x24ac): Section mismatch in reference from the function dma_controller_create() to the function .init.text:cppi_controller_start()
> > The function __devinit dma_controller_create() references
> > a function __init cppi_controller_start().
> > If cppi_controller_start is only used by dma_controller_create then
> > annotate cppi_controller_start with a matching annotation.
> 
> > This warning is there due to the deficiency in the commit 07a67bbb (usb: musb:
> > Make dma_controller_create __devinit).
> 
> > Since the start() method is only called from musb_init_controller() which is
> > marked '__devinit', mark cppi_controller_start() '__devinit' and also mark
> > cppi_pool_init() as such since it gets called from that function, to avoid
> > another section mismatch warning...
> 
> > Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx # 3.7+
> 
> > ---
> > This patch is atop of 'musb' branch of Felipe's tree...
> 
> > Would be good to have it in 3.7 as an amendment to the patch
> > that went into 3.7-rc1, but if not, I CC'ed stable kernels.
> 
>    Felipe, are you going to finally queue this one?

for v3.8-rc. The merge window isn't even open yet, chill out.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux