RE: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Michał,

Thanks for comments, I generally agree.

On Thursday, November 22, 2012 10:00 PM Michal Nazarewicz wrote:

<snip>

> >
> > Then specific functions to be run follow, e.g.:
> >
> > echo MassStorage > /cfg/usb-function-gadget/G1/C1/F1/name
> 
> Why not
> 
> 	mkdir /cfg/usb-function-gadget/G1/C1/F1/MassStorage
> 
> ?
>

In fact, if the directories layout you proposed is used, the
mkdir will be used and in a different directory.

 
<snip>

> >
> > echo 1 > /cfg/usb-function-gadget/G1/ready
> 
> This is temporary though, right?  In the future, we want to have UDCs in
> configfs as well and link the two together?

Right. I should have said it explicitly in the cover letter.

> Would it be possible to let the user just do:
> 
> 	rmdir /cfg/usb-function-gadget/G1
> 
> and make the module unbind the gadget and recursively remove all the
> directories?  Specifically the requirement of:
> 
> 	echo > /cfg/usb-function-gadget/G1/C1/F1/MassStorage/lun0/file
> 
> seems shady to me because this makes it impossible to have a generic way
> of unloading gadgets.  Ie. if I don't know that this gadget has a mass
> storage function which requires empty string to be written to LUN's file,
> than I won't be able to unload it.

Yeah, would be nice from the user's point of view.

Andrzej


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux