On Fri, Nov 23, 2012 at 02:53:41PM +0800, Peter Chen wrote: > On Wed, Nov 21, 2012 at 03:06:32PM +0100, Michael Grzeschik wrote: > > This adds mx53 as the next user of the usbmisc driver and makes it > > possible to disable the overcurrent-detection of the internal phy. > > > > Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx> > > Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> > > --- > > Changes since v2: > > * added defines for register offsets and bitmasks > > * fixed disable_oc option for all ports > > > > drivers/usb/chipidea/usbmisc_imx.c | 51 ++++++++++++++++++++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > > > diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c > > index e090e0f..b1811df 100644 > > --- a/drivers/usb/chipidea/usbmisc_imx.c > > +++ b/drivers/usb/chipidea/usbmisc_imx.c > > @@ -19,6 +19,13 @@ > > > > #define USB_DEV_MAX 4 > > > > +#define MX53_USB_OTG_PHY_CTRL_0_OFFSET 0x08; > > +#define MX53_USB_UH2_CTRL_OFFSET 0x14; > > +#define MX53_USB_UH3_CTRL_OFFSET 0x18; > > +#define MX53_BM_OVER_CUR_DIS_H1 BIT(5) > > +#define MX53_BM_OVER_CUR_DIS_OTG BIT(8) > > +#define MX53_BM_OVER_CUR_DIS_UHx BIT(30) > > + > > #define MX6_BM_OVER_CUR_DIS BIT(7) > > As every SoC platform's non-core register mapping is different, > it is better to use .h to put register bit definition What do the different register mapping have to do with putting the definitions in .h files or not? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
