Re: [PATCH 08/17] usb/gadget: convert loopback to new function interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/08/2012 03:24 PM, Felipe Balbi wrote:
commit log.
added

| This patch converts the f_loopback file to the USB-function module.

Signed-off-by: Sebastian Andrzej Siewior<bigeasy@xxxxxxxxxxxxx>

[ snip ]

@@ -129,10 +113,12 @@ static struct usb_otg_descriptor otg_descriptor = {
  	.bmAttributes =		USB_OTG_SRP | USB_OTG_HNP,
  };

-const struct usb_descriptor_header *otg_desc[] = {
+static const struct usb_descriptor_header *otg_desc[] = {
  	(struct usb_descriptor_header *)&otg_descriptor,
  	NULL,
  };
+#else
+extern const struct usb_descriptor_header *otg_desc[];

you let otg_desc to be provided by somewhere else ? This looks like a
recipe for re-definition of otg_desc :-)

This is how it was before (moved from the .h) and is only here to avoid
a compile error. In the else case there will be an if (0) block and the
compiler complains about undefined otg_desc.
So an ifdef would do the job I guess.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux