Re: [PATCH v3 0/4] Adding usb2.0 host-phy support for exynos5250

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Nov 06, 2012 at 07:23:12PM +0530, Vivek Gautam wrote:
> Hi Balbi,
> 
> 
> On Tue, Nov 6, 2012 at 6:44 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> > Hi,
> >
> > On Mon, Oct 29, 2012 at 07:12:36PM +0530, Vivek Gautam wrote:
> >> This patchset is based on the work by Praveen Paneri for
> >> samsung-usbphy driver:
> >> http://comments.gmane.org/gmane.linux.kernel.samsung-soc/12653
> >>
> >> Changes from v2:
> >>  - Using "EXYNOS5_PHY_" as common prefix along with exact names for
> >>    PHY SFRs for register definitions
> >>  - Using register names with bit macros to make things more clear.
> >>  - Removed parentheses around 0x230 in definition for EXYNOS5_USB_CFG
> >>    in [patch 2/4 v2].
> >>
> >> Tested on smdk5250 target with usb-next branch along with arch patches
> >> for exynos5250:
> >> http://thread.gmane.org/gmane.linux.kernel.samsung-soc/13042
> >> http://thread.gmane.org/gmane.linux.kernel.samsung-soc/13048
> >>
> >> Vivek Gautam (4):
> >>   usb: phy: samsung: Add host phy support to samsung-phy driver
> >>   ARM: Exynos5250: Enabling samsung-usbphy driver
> >>   USB: ehci-s5p: Add phy driver support
> >>   USB: ohci-exynos: Add phy driver support
> >
> > I really don't know what to do with this series. I know it depends on
> > the other PHY changes which I have in my queue, but it touches too much
> > arch specific code, plus the USB Host code which I don't maintain.
> >
> 
> True, that it has dependency on the work by Praveen Paneri for samsung-usbphy
> driver plus the arch support patches.
> 
> This is based on usb-next branch, so the host-code can be taken care of ?
> 
> > On top of all that, I have no platform to test these patches, which
> > makes me even more worried about signing off under this series ;-)
> >
> The patches have however been tested. The two patches:
> "USB: ehci-s5p: Add phy driver support",
> "USB: ohci-exynos: Add phy driver support" have been acked by Jingoo Han
> based on the patch-series.
> 
> Possibly Kukjin Kim can help on this one.
> 
> Kukjin,
> Can we have a thought on this please.
> 
> > Would it be ok if we delay this to v3.9 ? At least the dependency with
> > other PHY changes would be dropped by then.
> >
> This changes are almost in shape ;-) and i am updating the next patchset soon.
> If possible can we try to get this in 3.8 please. :-)

we can try, but I'd like to minimize the amount of code outside of
drivers/usb/ I take in my tree. If there's any way to split the series
so it makes my life easier, I'd be really glad.

Also, I can't apply arch/* patches without proper Acked-bys, so Kukjin
would need to help us out there too :-)

cheers

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux