Re: [RFC] Fix build error by making ChipIdea host a normal EHCI driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> writes:

> Alexander:
>
> The patch below (which is meant to apply to the linux-next tree) fixes
> a build error I introduced recently.  However I don't know if it will
> work properly as the ChipIdea host driver.  Can you verify that it is
> okay?

It does the job, yes.
There is a problem with setting has_tt, though, for me it starts with

commit c73cee717e7d5da0698acb720ad1219646fe4f46
Author: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
Date:   Wed Oct 31 13:21:06 2012 -0400

which drops ci_ehci_setup(), which sets has_tt before ehci_setup(), and
we need to keep it like that. One quick and obvious way is doing it in
the reset() callback of ci_overrides. Need some time to look at the new
ehci code and figure out what's best.

Even though chipidea host remains broken, for this particular patch,
[FWIW]:

Acked-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>

I'll send fixes for chipidea separately.

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux