Re: [PATCH] usb: gadget: ncm: correct endianess conversion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 01-11-2012 19:16, Dmytro Milinevskyy wrote:

Convert USB descriptor's fields to CPU byte order before using locally in USB
NCM gadget driver.
Tested on MIPS32 big-endian device.

Signed-off-by: Dmytro Milinevskyy <milinevskyy@xxxxxxxxx>
---
  drivers/usb/gadget/f_ncm.c | 12 ++++++++----
  1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/gadget/f_ncm.c b/drivers/usb/gadget/f_ncm.c
index b651b52..a7cdd47 100644
--- a/drivers/usb/gadget/f_ncm.c
+++ b/drivers/usb/gadget/f_ncm.c
[...]
@@ -869,15 +869,19 @@ static struct sk_buff *ncm_wrap_ntb(struct gether *port,
      struct sk_buff    *skb2;
      int        ncb_len = 0;
      __le16        *tmp;
-    int        div = ntb_parameters.wNdpInDivisor;
-    int        rem = ntb_parameters.wNdpInPayloadRemainder;
+    int        div;
+    int        rem;
      int        pad;
-    int        ndp_align = ntb_parameters.wNdpInAlignment;
+    int        ndp_align;
      int        ndp_pad;
      unsigned    max_size = ncm->port.fixed_in_len;
      struct ndp_parser_opts *opts = ncm->parser_opts;
      unsigned    crc_len = ncm->is_crc ? sizeof(uint32_t) : 0;
  +    div = le16_to_cpu(ntb_parameters.wNdpInDivisor);

    Probably corrupt patch -- there shouldn't be spaces before '+'.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux