Re: [PATCH 0/3] USB: EHCI: Start splitting up the driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 01, 2012 at 11:12:52AM -0400, Alan Stern wrote:
> Greg:
> 
> This series of patches begins the process of splitting ehci-hcd up into 
> a core library module and multiple independent platform-specific driver 
> modules.  The purpose of this change is to allow people and 
> distributions to build systems that support more than one platform 
> driver for EHCI (not counting PCI and a handful of others).
> 
> Patch 1/3 prepares the way by exporting a few functions from ehci-hcd
> and adding a new mechanism for platform-specific drivers to initialize
> their hc_driver structures.  This deserves to be done in the core
> because almost all of the entries in these structures are pure
> boilerplate -- practically none of the drivers need to override more
> than three of the standard core values.
> 
> Patches 2/3 and 3/3 separate out ehci-pci and ehci-platform into 
> independent driver modules.  Other platform-specific drivers can follow 
> the same pattern as time goes on.  It should be easy now that there are 
> two examples to imitate.

After these patches applied, I'm getting the following build warnings:

WARNING: drivers/usb/host/ehci-hcd: 'ehci_init_driver' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
WARNING: drivers/usb/host/ehci-hcd: 'ehci_resume' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
WARNING: drivers/usb/host/ehci-hcd: 'ehci_suspend' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
WARNING: drivers/usb/host/ehci-hcd: 'ehci_setup' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko

Care to send a follow-on patch to fix it up?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux