Re: [PATCH] usb: musb: ux500: fix 'musbid' undeclared error in ux500_remove()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi


On Tue, Oct 23, 2012 at 11:42 AM, Wei Yongjun <weiyj.lk@xxxxxxxxx> wrote:
> commit 65b3d52d02a558fbfe08e43688e15390c5ab3067
> (usb: musb: add musb_ida for multi instance support)
> used musbid in ux500_remove() but nerver declared it.

The above message doesnot match with your fix. You say ux500_remove is
using musbhid but build error is in probe.

I also dont see anywhere in the code we use this variable musbid.


>
> I found this in x86_64 platform, but not sure whether
> this is a error on the correct ARCH.
>
> $ make drivers/usb/musb/ux500.o
> make[1]: Nothing to be done for `all'.
> make[1]: Nothing to be done for `relocs'.
>   CHK     include/generated/uapi/linux/version.h
>   CHK     include/generated/utsrelease.h
>   UPD     include/generated/utsrelease.h
>   CALL    scripts/checksyscalls.sh
>   CC      drivers/usb/musb/ux500.o
> drivers/usb/musb/ux500.c: In function 'ux500_probe':
> drivers/usb/musb/ux500.c:78:2: error: 'musbid' undeclared (first use in this function)
> drivers/usb/musb/ux500.c:78:2: note: each undeclared identifier is reported only once for each function it appears in
> make[1]: *** [drivers/usb/musb/ux500.o] Error 1
> make: *** [drivers/usb/musb/ux500.o] Error 2
>
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/usb/musb/ux500.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/musb/ux500.c b/drivers/usb/musb/ux500.c
> index d62a91f..0e62f50 100644
> --- a/drivers/usb/musb/ux500.c
> +++ b/drivers/usb/musb/ux500.c
> @@ -65,7 +65,7 @@ static int __devinit ux500_probe(struct platform_device *pdev)
>         struct platform_device          *musb;
>         struct ux500_glue               *glue;
>         struct clk                      *clk;
> -
> +       int                             musbid;
>         int                             ret = -ENOMEM;
>
>         glue = kzalloc(sizeof(*glue), GFP_KERNEL);
> --
> 1.7.11.7
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux