Hi,
On Wed, Oct 24, 2012 at 04:43:12PM +0530, Mohan V wrote:
> Hello All,
>
> We are working on OMAP4430 based board which has EHCI and OHCI ports and
> are testing OHCI functionality. We are using kernel-3.4.
>
> When the USB bus is in suspend, a device connected to OHCI port does
> not get detected, whereas the device connected to EHCI port is getting detected.
>
> We are testing using the below commands:
>
> echo enabled > /sys/bus/usb/devices/usb2/power/wakeup
> echo enabled > /sys/bus/usb/devices/2-2/power/wakeup
> echo auto > /sys/bus/usb/devices/usb2/power/control
> echo auto > /sys/bus/usb/devices/2-2/power/control
>
> We see that after making the below change in "ohci_irq", the device
> gets detected.
> ---------------------------------------------------------------------------------------------------
> --- a/drivers/usb/host/ohci-hcd.c
> +++ b/drivers/usb/host/ohci-hcd.c
> @@ -819,7 +819,7 @@ static irqreturn_t ohci_irq (struct usb_hcd *hcd)
> * to turn on RHSC along with RD. But for remote wakeup events
> * this might not happen.
> */
> - else if (ints & OHCI_INTR_RD) {
> + if (ints & OHCI_INTR_RD) {
> ---------------------------------------------------------------------------------------------------
> Even in the OHCI specification (Sec 5.3 page 80), it is recommended to
> check individual bits
> (RHSC and RD).
>
> Can you please let us know if this change is valid and will not cause
> any regression?
This change makes sense to me. Unless we are dead sure those IRQ bits
are mutually exclusive.
Mohan, can you re-send this as a proper patch ? You can read through
Documentation/SubmittingPatches. I strongly suggest getting acquainted
with git and using git send-email to send the final patch.
cheers
--
balbi
Attachment:
signature.asc
Description: Digital signature
