Re: [PATCH 07/16] usb/gadget: remove c->highpseed = true from f_mini and uac1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/24/2012 12:27 PM, Sergei Shtylyov wrote:
Hello.

On 23-10-2012 0:15, Sebastian Andrzej Siewior wrote:

Whether highspeed configuration is valid or not is something that
composite decides and not the gadget. That gadget can only provide the
required descriptors for it.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
[...]

diff --git a/drivers/usb/gadget/f_uac1.c b/drivers/usb/gadget/f_uac1.c
index 1a5dcd5..c8ed41b 100644
--- a/drivers/usb/gadget/f_uac1.c
+++ b/drivers/usb/gadget/f_uac1.c
@@ -667,7 +667,6 @@ f_audio_bind(struct usb_configuration *c, struct
usb_function *f)
* both speeds
*/
if (gadget_is_dualspeed(c->cdev->gadget)) {
- c->highspeed = true;
f->hs_descriptors = usb_copy_descriptors(f_audio_desc);
}

Remove now unneeded {} please.

It is done later in the series. Look for
"usb/gadget: always update HS/SS descriptors and create a copy of them"

checkpatch.pl should have warned here.
It says:

|total: 0 errors, 0 warnings, 0 checks, 1273 lines checked

WBR, Sergei

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux