Re: [PATCH 03/32 v4] MIPS: Loongson 1B: use ehci-platform instead of ehci-ls1x.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 23 October 2012 10:20:15 Alan Stern wrote:
> On Tue, 23 Oct 2012, Florian Fainelli wrote:
> 
> > Hi Kelvin,
> > 
> > On Tuesday 23 October 2012 16:13:01 Kelvin Cheung wrote:
> > > Thank Florian.
> > > It looks great.
> > > However, you forget to remove corresponding section in
> > > drivers/usb/host/ehci-hcd.c
> > > ...
> > > #ifdef CONFIG_MACH_LOONGSON1
> > > #include "ehci-ls1x.c"
> > > #define PLATFORM_DRIVER         ehci_ls1x_driver
> > > #endif
> > 
> > Indeed, my bad I will follow up with some fixes for this patchset anyway.
> > Thank you!
> 
> Speaking of followups...
> 
> Have you checked to see whether any of these changes should affect the
> definitions of CONFIG_USB_EHCI_BIG_ENDIAN_MMIO and
> CONFIG_USB_EHCI_BIG_ENDIAN_DESC (and likewise for OHCI)?  Are they
> still getting set whenever they are needed?

Yes I checked the defconfigs to see whether they selected these options, and
also I kept, when existing the original CONFIG symbol, so that one would also
select these two options if needed. We should be ok from what I checked.
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux