Re: [PATCH 0/6] UVC gadget cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Felipe,

On Tuesday 23 October 2012 16:52:31 Felipe Balbi wrote:
> On Tue, Oct 23, 2012 at 09:50:10PM +0800, Bhupesh SHARMA wrote:
> > On Tuesday, October 23, 2012 6:31 PM Laurent Pinchart wrote:
> > > On Wednesday 01 August 2012 14:57:09 Laurent Pinchart wrote:
> > > > Hi,
> > > > 
> > > > These 6 patches clean up the UVC gadget driver after Bhupesh Sharma's
> > > > "UVC webcam gadget related changes" patch series. They're what I would
> > > > have asked during patch review if the original patches hadn't been
> > > > merged before I got a change to review them.
> > > > 
> > > > Bhupesh, would you mind testing the patches, especially the ones that
> > > > touch super speed support ? I have no SS hardware I can test them on.
> > > 
> > > Ping ? Could you please test this patch set ? I've rebased it on top of
> > > the latest master branch in Linus' tree, the result is available in the
> > > uvcvideo- gadget branch of git://linuxtv.org/pinchartl/uvcvideo.git,
> > > including two of your fixes. I'll then work on your videobuf2 patch.
> > 
> > Sorry for the delay. I had tested the patch-set and completely forgot
> > about updating you with the results (I could not get the UVC gadget to
> > enumerate properly with your patches).
> > 
> > I was completely busy with making the UVC working on a NOMMU
> > architecture for a customer and hence the delay.  I will start sending
> > you the test results and new patches I have generated locally for the
> > NOMMU architecture from the next week.
> > 
> > Sorry again for the delay and thanks for your patience :)
> > 
> > Regards,
> > Bhupesh
> > 
> > > > Laurent Pinchart (6):
> > > >   usb: gadget/uvc: Clarify comment about string descriptors
> > > >   usb: gadget/uvc: Rename STATUS_BYTECOUNT to
> > > >   
> > > >     UVC_STATUS_MAX_PACKET_SIZE
> > > >   
> > > >   usb: gadget/uvc: Fix coding style issues introduced by SS support
> > > >   usb: gadget/uvc: Merge the SS/HS/FS status endpoint descriptors
> > > >   usb: gadget/uvc: Merge the streaming maxpacket and mult parameters
> > > >   usb: gadget/uvc: Configure the streaming endpoint based on the speed
> > > >  
> > > >  drivers/usb/gadget/f_uvc.c |  220 ++++++++++++++++++-----------------
> > > >  drivers/usb/gadget/f_uvc.h |   12 +-
> > > >  2 files changed, 110 insertions(+), 122 deletions(-)
> 
> I don't seem to have the patches in my inbox. I'd like to have the
> patches with proper Tested-by tags so I can queue them for v3.8 merge
> window.

It looks like the patches broke enumeration, so a v2 will be needed.

-- 
Regards,

Laurent Pinchart

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux