Hi, On Tue, Oct 23, 2012 at 04:23:19PM +0530, Venu Byravarasu wrote: > > -----Original Message----- > > From: Venu Byravarasu > > Sent: Monday, October 22, 2012 4:04 PM > > To: 'balbi@xxxxxx' > > Cc: stern@xxxxxxxxxxxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; linux- > > usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > > Subject: RE: [PATCH v3 resend] USB: PHY: Re-organize Tegra USB PHY driver > > > > > > > > what is this SOC dependent PHY driver ? > > > > SOC dependent PHY driver actually deals with the PHY interface > > programming. > > e.g. please see code present in tegra2_usb_driver.c. > > > > > What sort of dependencies are > > > there ? Those differences should be handled with runtime checks. > > > > As PHY related bugs got fixed across different set of SOCs apart from > > adding few features, wanted to separate this out from common PHY > > functionality. This will help us in adding support for different SOCs with > > minimum set of changes. > > Felipe, > > Please let me know if you have any more questions on this patch. > If not, can you please merge this? Like I said before, those differences should be handled by runtime checks, you shouldn't need separate files for that. What you need to do is implement a single PHY driver which can handle all tegras known to date, later you can add support for new tegras by patching a few things here and there. -- balbi
Attachment:
signature.asc
Description: Digital signature
