Re: [PATCH 1/2] usb: musb: use DMA mode 1 whenever possible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/23/2012 01:02 PM, ABRAHAM, KISHON VIJAY wrote:
> Hi,
> 
> On Wed, Aug 8, 2012 at 11:28 AM, Rajaram R <rajaram.officemail@xxxxxxxxx> wrote:
>> On Tue, Aug 7, 2012 at 6:39 PM, Roger Quadros <rogerq@xxxxxx> wrote:
>>> Do not rely on any hints from gadget drivers and use DMA mode 1
>>> whenever we expect data of at least the endpoint's packet size and
>>> have not yet received a short packet.
>>
>> Could you please let us know what all combination this was tested ?
>> What will happen if the request length is 513 ?
>>
>>>
>>> The last packet if short is always transferred using DMA mode 0.
>>>
>>> This patch fixes USB throughput issues in mass storage mode for
>>> host to device transfers.
>>>
>>> Signed-off-by: Roger Quadros <rogerq@xxxxxx>
> 
> This commit is causing regression while using the test gadget.
> 
> output of ./test.sh in usb host machine
> 
> ./test.sh
> ./test.sh: 31: ./test.sh: declare: not found
> TESTING:  control out in
> Tue Oct 23 15:25:29 IST 2012
> ** Control test cases:
> test 9: ch9 postconfig
> /dev/bus/usb/001/020 test 9,   63.749319 secs
> test 10: control queueing
> /dev/bus/usb/001/020 test 10,   10.417282 secs
> test 14: control writes
> /dev/bus/usb/001/020 test 14,    4.579272 secs
> 
> assuming sink-src configuration
> ** Host Write (OUT) test cases:
> test 1: 5000 transfers, same size
> <stays here infinitely>
> 

Thanks for letting know. Will take a look.

regards,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux