On Mon, Oct 22, 2012 at 06:45:36AM +1100, Bernard Blackham wrote: > This patch cleans up much of the locking in usbip, as well as fixing > some logic errors. In particular: > > - some spinlocks were taken with interrupts disabled in some > places, but not always. > > - many error paths duplicated unwinding code; these have been > changed to use conventional goto idioms for unwinding on error. > > - usb_hcd_giveback_urb was called incorrectly when vhci_urb_enqueue > returned an error. > > - vhci_device_unlink_cleanup did not properly clean up URBs which > had not yet been transmitted yet. That's a lot to do all in one patch, making it hard to review. Can you split this up into smaller pieces, one patch per thing you do above, so we can apply it? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
