On Mon, Oct 22, 2012 at 11:39:26AM -0700, Hemant Kumar wrote: > Hi > > I have come across a scenario where usbnet can leak memory allocated to tx > urb. > > usbnet Driver anchors the tx urbs and defers the urb submission if a > transmit request comes when the interface is suspended. Anchoring urb > increments the urb reference count. These deferred urbs are later accessed > by calling usb_get_from_anchor()for submission during interface resume. > usb_get_from_anchor()unanchors the urb but urb reference count remains > same. > This causes the urb reference count to remain non-zero after > usb_free_urb() gets called and urb never gets freed.Hence call > usb_put_urb() after anchoring the urb to properly balance the reference > count for these deferred urbs. Also,unanchor these deferred urbs during > disconnect, to free them up. > > Here is the change which could fix it. Please review. Please use scripts/get_maintainer.pl to determine the correct people who should be reviewing this. Also note what kernel version you are looking at when you send patches, odds are you aren't looking at the latest version of the driver, but I really don't know given the lack of context... greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
