Hi, On Fri, Oct 19, 2012 at 10:29:35AM -0600, Stephen Warren wrote: > On 10/19/2012 09:35 AM, Felipe Balbi wrote: > > Hi, > > > > On Fri, Oct 19, 2012 at 04:08:05PM +0530, Venu Byravarasu wrote: > >> NVIDIA produces several Tegra SoCs viz Tegra20, Tegra30 etc. In > >> order to support USB PHY drivers on these SoCs, existing PHY > >> driver is split into SoC agnostic common USB PHY driver and > >> Tegra20-specific USB phy driver. This will facilitate easy > >> addition and deletion of phy drivers for Tegra SoCs. > >> > >> Signed-off-by: Venu Byravarasu <vbyravarasu@xxxxxxxxxx> > > > > I was reading this "driver" more closely and I have a bunch of > > questions about it, but the most important of all of them is: "why > > isn't that a real PHY driver ?". It doesn't have a probe() > > function, it doesn't use struct usb_phy to represent the PHY, it > > has a bunch of tegra-specific APIs and we can't let those > > continue. > > One question here: If the PHY "driver" API changes, there will need to > be a bunch of ehci-tegra.c changes too. Will you take all those hmm.. indeed. > through the PHY tree? If you expect to do that, then I'd like to I can take those if Alan is ok with it :-) Alan ? > request you also take: > > usb: host: tegra remove include of <mach/iomap.h> > http://www.spinics.net/lists/linux-usb/msg72429.html > > ... since that should get merged before any large changes to > ehci-tegra.c; it's the EHCI equivalent of the PHY patch you already > merged. > > (The same request applies to put that into a branch I can pull into > the Tegra tree as a basis for cleanup in the Tegra tree) sure, that should be simple enough to do ;-) -- balbi
Attachment:
signature.asc
Description: Digital signature
