On Mon, Oct 15, 2012 at 03:42:55PM +0200, Johan Hovold wrote: > On Tue, Oct 09, 2012 at 01:05:46PM -0400, Alan Stern wrote: > > On Tue, 9 Oct 2012, Greg KH wrote: > > > > > Ugh, that "simple" patch has turned up more bugs in drivers than > > > anything I know of in recent history. [...] > I've fixed the cp210x and pl2303. Not counting the garmin deref fixed > by Alan, a quick grep and audit reveals at least 22 memory leaks and 4 > NULL derefs in usb/serial: > > drivers/usb/serial/ark3116.c > drivers/usb/serial/belkin_sa.c > drivers/usb/serial/cyberjack.c > drivers/usb/serial/cypress_m8.c > drivers/usb/serial/digi_acceleport.c > drivers/usb/serial/f81232.c > drivers/usb/serial/io_edgeport.c > drivers/usb/serial/io_ti.c > drivers/usb/serial/iuu_phoenix.c > drivers/usb/serial/keyspan.c > drivers/usb/serial/keyspan_pda.c > drivers/usb/serial/kl5kusb105.c > drivers/usb/serial/kobil_sct.c > drivers/usb/serial/mct_u232.c > drivers/usb/serial/mos7720.c > drivers/usb/serial/mos7840.c > drivers/usb/serial/omninet.c > drivers/usb/serial/opticon.c > drivers/usb/serial/oti6858.c > drivers/usb/serial/qcserial.c > drivers/usb/serial/quatech2.c > drivers/usb/serial/sierra.c > drivers/usb/serial/spcp8x5.c > drivers/usb/serial/ssu100.c > drivers/usb/serial/ti_usb_3410_5052.c > drivers/usb/serial/whiteheat.c > > I'll try to fix a few more... With the fixes I posted Monday and today, and with the removal of two false positives, the list now reads: drivers/usb/serial/digi_acceleport.c drivers/usb/serial/keyspan.c drivers/usb/serial/mct_u232.c drivers/usb/serial/mos7720.c drivers/usb/serial/mos7840.c drivers/usb/serial/omninet.c drivers/usb/serial/quatech2.c drivers/usb/serial/sierra.c drivers/usb/serial/whiteheat.c All have confirmed memory leaks at release (e.g. device disconnect). Some of these have quirks that makes them a bit more tedious to fix especially without access to the actual hardware. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
