Re: [RFC v3][PATCH 1/2] usb: gadget: Add USB Functions Gadget

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Oct 17, 2012 at 11:43:11AM +0200, Andrzej Pietrasiewicz wrote:
> Demonstrate a USB gadget configured entirely through configfs.
> This is a work in progress.
> 
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> 
> ---
>  drivers/usb/gadget/Kconfig         |   12 +
>  drivers/usb/gadget/Makefile        |    2 +
>  drivers/usb/gadget/usb_functions.c | 1204 ++++++++++++++++++++++++++++++++++++
>  drivers/usb/gadget/usb_functions.h |   32 +
>  4 files changed, 1250 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/usb/gadget/usb_functions.c
>  create mode 100644 drivers/usb/gadget/usb_functions.h
> 
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index dfb51a4..2229acd 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -521,6 +521,18 @@ choice
>  
>  # this first set of drivers all depend on bulk-capable hardware.
>  
> +config USB_FG
> +	tristate "USB Functions Gadget (EXPERIMENTAL)"
> +	select USB_LIBCOMPOSITE
> +	depends on EXPERIMENTAL && CONFIGFS_FS
> +	help
> +	  USB Functions Gadget is a device which aggregates a number of
> +	  USB functions. The gadget is composed by userspace through a
> +	  configfs interface, which enables specifying what USB
> +	  configurations the gadget is composed of, what USB functions
> +	  a USB configuration is composed of and enabling/disabling
> +	  the gadget.
> +
>  config USB_ZERO
>  	tristate "Gadget Zero (DEVELOPMENT)"
>  	select USB_LIBCOMPOSITE
> diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile
> index 307be5f..0f8b421 100644
> --- a/drivers/usb/gadget/Makefile
> +++ b/drivers/usb/gadget/Makefile
> @@ -38,6 +38,7 @@ obj-$(CONFIG_USB_MV_U3D)	+= mv_u3d_core.o
>  #
>  # USB gadget drivers
>  #
> +g_usb_functions-y		:= usb_functions.o

this is wrong. we don't want *another* gadget driver. We want to get rid
of the ones we have. The end goal is to keep only f_* files in kernel.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux