On Sat, Oct 13, 2012 at 06:40:24PM +0530, Vikas Sajjan wrote:
> Adding the suspend and resume functionality for the XHCI driver
please do better on your commit log.
> Signed-off-by: Abhilash Kesavan <a.kesavan@xxxxxxxxxxx>
> Signed-off-by: Vikas C Sajjan <vikas.sajjan@xxxxxxxxxx>
> CC: Doug Anderson <dianders@xxxxxxxxxxxx>
> ---
> drivers/usb/host/xhci-plat.c | 33 +++++++++++++++++++++++++++++++++
> 1 files changed, 33 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index df90fe5..15c7c89 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -185,11 +185,44 @@ static int xhci_plat_remove(struct platform_device *dev)
> return 0;
> }
>
> +#ifdef CONFIG_PM
> +static int xhci_plat_suspend(struct device *dev)
> +{
> + struct usb_hcd *hcd = dev_get_drvdata(dev);
> + struct xhci_hcd *xhci = hcd_to_xhci(hcd);
> +
> + /* Make sure that the HCD Core has set state to HC_STATE_SUSPENDED */
> + if (hcd->state != HC_STATE_SUSPENDED ||
> + xhci->shared_hcd->state != HC_STATE_SUSPENDED)
> + return -EINVAL;
> +
> + return xhci_suspend(xhci);
> +}
> +
> +static int xhci_plat_resume(struct device *dev)
> +{
> + struct usb_hcd *hcdi = dev_get_drvdata(dev);
> + struct xhci_hcd *xhci = hcd_to_xhci(hcd);
> +
> + return xhci_resume(xhci, 0);
> +}
> +
> +static const struct dev_pm_ops xhci_plat_pm_ops = {
> + .suspend = xhci_plat_suspend,
> + .resume = xhci_plat_resume,
I believe you should be using SET_SYSTEM_PM_SLEEP_PM_OPS()
> +};
> +
> +#define XHCI_PLAT_PM_OPS (&xhci_plat_pm_ops)
> +#else
> +#define XHCI_PLAT_PM_OPS NULL
> +#endif
> +
> static struct platform_driver usb_xhci_driver = {
> .probe = xhci_plat_probe,
> .remove = xhci_plat_remove,
> .driver = {
> .name = "xhci-hcd",
> + .pm = XHCI_PLAT_PM_OPS,
> },
> };
> MODULE_ALIAS("platform:xhci-hcd");
> --
> 1.7.6.5
>
--
balbi
Attachment:
signature.asc
Description: Digital signature
