Hi,
On Wed, Oct 10, 2012 at 07:18:45PM -0700, Kuninori Morimoto wrote:
> renesas_usbhs can't handle scatter/gather type DMA.
> Thus, return -EINVAL is better than WARNING() on mod_gadget
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> ---
> drivers/usb/renesas_usbhs/mod_gadget.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c
> index 28478ce..40256bf 100644
> --- a/drivers/usb/renesas_usbhs/mod_gadget.c
> +++ b/drivers/usb/renesas_usbhs/mod_gadget.c
> @@ -180,7 +180,8 @@ static int usbhsg_dma_map_ctrl(struct usbhs_pkt *pkt, int map)
>
> if (map) {
> /* it can not use scatter/gather */
> - WARN_ON(req->num_sgs);
> + if (req->num_sgs)
> + return -EINVAL;
I would leave the WARN_ON. Did this even trigger at any point ? If it
did you found a bug on a gadget driver as those should be checking for
gadget->sg_supported flag before queueing a scatterlist to the
controller.
--
balbi
Attachment:
signature.asc
Description: Digital signature
