On Thursday 11 October 2012 16:14:02 Ming Lei wrote: > On Thu, Oct 11, 2012 at 12:11 PM, Oliver Neukum <oneukum@xxxxxxx> wrote: > > On Thursday 11 October 2012 11:18:22 Ming Lei wrote: > > >> Currently scsi disk can only be runtime suspended when the device is not > >> opened, so are you sure that the paging out above can cause IO on a suspend > >> usb mass storage disk which is not mounted or opened by utility now? > > > > We definitely do not wish to keep it that way. People at Intel are currently working > > on better power management for sd, which would allow full autosuspend. > > OK, got it. > > For auto-resume situation, it can be solved with switching the gpf_t flag > runtime inside helper, but I think it is better to do it after the sd's > full autosuspend is seen in -next tree. That depends on whether an API change would be necessary. Changing the code only when necessary is no problem. But the API I want to do right from the beginning if that is possible. This depends on whether you get in your extension to task_struct. If you do, we can certainly use it also for the suspend case. > For error handling case, it is inevitably for usbnet to allocate memory > with GFP_KERNEL because no usbnet drivers have implemented > .pre_reset and .post_reset callback, and no such actual problems > have been reported until now, so it should be OK to not consider the > case now. > > So could we merge the patch set[1-11] first? Given the solution for error handling you came up with, yes, we can. Would you resubmit? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
